feat: Add www.iab.org K8s configuration #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but for consistency
kesara
approved these changes
Jul 18, 2024
NGPixel
approved these changes
Jul 29, 2024
k8s/iabweb/memcached.yaml
Outdated
| runAsGroup: 65534 # nobody | ||
| - image: "memcached:1.6-alpine" | ||
| imagePullPolicy: IfNotPresent | ||
| args: ["-m", "1024"] |
There was a problem hiding this comment.
Does it actually need 1GB? Consider using a smaller value.
There was a problem hiding this comment.
Reduced to 256 MB.
|
New commits have been pushed including adding a |
as already handled by namePrefix
kesara
reviewed
Aug 1, 2024
kesara
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIPReady for review nowResolves #479
Using the existing
k8s/ietfwebas a base.This will give you a better view for the diffs:
https://github.com/microamp/www/compare/ce80e80..1def680Update: https://github.com/microamp/www/compare/ce80e80..773fcd3