Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BlogPage may only be created under BlogIndexPage #401

Merged
merged 1 commit into from
May 7, 2024

Conversation

mgax
Copy link
Contributor

@mgax mgax commented Apr 3, 2024

Fix #337.
Fix #271.

The blog page template depends on its parent page being a BlogPageIndex, so it crashes if its parent is anything else.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.73%. Comparing base (4ad3143) to head (336946f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
+ Coverage   82.72%   82.73%   +0.01%     
==========================================
  Files         124      124              
  Lines        2599     2601       +2     
==========================================
+ Hits         2150     2152       +2     
  Misses        449      449              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kesara kesara changed the base branch from main to feat/modern-footer April 23, 2024 21:08
@kesara kesara merged commit 18814ea into ietf-tools:feat/modern-footer May 7, 2024
5 checks passed
@mgax mgax deleted the fix/blog-page-parent branch May 8, 2024 07:07
@kesara kesara mentioned this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants