Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force same image and tag for the wagtail service and the cron jobs #444

Closed
microamp opened this issue May 16, 2024 · 0 comments · Fixed by #445
Closed

Force same image and tag for the wagtail service and the cron jobs #444

microamp opened this issue May 16, 2024 · 0 comments · Fixed by #445
Labels
internal Fix internally

Comments

@microamp
Copy link
Contributor

In values.yaml currently, we have multiple places where we specify image.

wagtail:
  name: wagtail
  image:
    repository: "ghcr.io/ietf-tools/www"
    pullPolicy: IfNotPresent
    # Overrides the image tag whose default is the chart appVersion.
    # tag: "v2.1.10"
cronjob:
  crons:
    - name: mgmt-hourly
      schedule: "0 * * * *" # "At minute 0."
      timeZone: "Etc/UTC"
      image:
        repository: "ghcr.io/ietf-tools/www"
        pullPolicy: IfNotPresent
        # tag: "v2.1.10"
      command: ["python", "/app/manage.py", "publish_scheduled"]
    - name: mgmt-weekly
      schedule: "30 0 * * 0" # "At 00:30 on Sunday."
      timeZone: "Etc/UTC"
      image:
        repository: "ghcr.io/ietf-tools/www"
        pullPolicy: IfNotPresent
        # tag: "v2.1.10"
      command: ["python", "/app/manage.py", "update_index"]

However, there's no good reason for the cron jobs to use a different image repository and tag. Consider removing image from each of the crons defined above and making them use the same image specified under wagtail. This will prevent them from becoming out of sync. Also, there will be two fewer variables to consider in the deployment code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Fix internally
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant