Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production settings as default in Helm chart #436

Closed
microamp opened this issue Apr 26, 2024 · 1 comment · Fixed by #437
Closed

Use production settings as default in Helm chart #436

microamp opened this issue Apr 26, 2024 · 1 comment · Fixed by #437

Comments

@microamp
Copy link
Contributor

It's better to use ietf.settings.production (where DEBUG is False) in both staging and prod.

@rjsparks
Copy link
Member

Note that this is only ok (as in not dangerous) because the runtime code currently has no switches based on a notion of "am I in production or not" as the datatracker does. If such code ever comes in (to our extensions, or into wagtail, (or maybe we haven't discovered it in wagtail)), unintended unpleasant consequences become very likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants