-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup linting #379
Comments
We have been using ruff at Torchbox lately, as a replacement for both flake8 and black (they recently added support for code formatting), with good results. It's much faster, has more configuration options, and replaces multiple tools with a single one. Is there a strong preference to use flake8 and black? |
There is a preference for black, because it isn't configurable. I've not noticed black being slow - are the speed differences in replacing flake8? I have no qualms replacing flake8. Does ruff undo some of the heavy-handed "there is only one way" formatting rules that are at the core of black's principles? |
It does provide more options, but the defaults aim to be compatible with black:
I'd argue there is no meaningful downside to using the ruff formatter with the default settings, perhaps with a comment in its configuration block to the effect of we stick to black's formatting rules, please don't tweak the settings, and a link to the styleguide (which, in turn, would document a preference for black-style formatting). |
Set up linting with flake8 / black.
The text was updated successfully, but these errors were encountered: