Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to undo/redo edits should span Save actions #33

Open
ajeanmahoney opened this issue Feb 12, 2024 · 5 comments
Open

The ability to undo/redo edits should span Save actions #33

ajeanmahoney opened this issue Feb 12, 2024 · 5 comments
Assignees
Labels
bug Something isn't working priority: normal

Comments

@ajeanmahoney
Copy link
Collaborator

A user should be able to type, save, and then undo (or redo) the edits that they made before the save action. Currently, neither undo nor redo work if the document was just saved. The edit buffer can be flushed when the document is closed, though.

@ajeanmahoney
Copy link
Collaborator Author

I can undo/redo basic edits before saving, but I can't undo a Reindent action even if it's the only edit I've made and I haven't saved.

@NGPixel
Copy link
Member

NGPixel commented Mar 1, 2024

Are you saving / under / redo via the toolbar or within the editor using keyboard shortcuts (Cmd+S, Cmd+Z, Cmd+Y) ?

@ajeanmahoney
Copy link
Collaborator Author

Keyboard shortcuts

@NGPixel NGPixel self-assigned this Oct 9, 2024
@NGPixel NGPixel added the bug Something isn't working label Oct 9, 2024
@NGPixel
Copy link
Member

NGPixel commented Oct 9, 2024

I'm not able to replicate this bug? I tried both scenarios:

Test 1:

  • Open a document
  • Make basic edits
  • Save (Cmd + S)
  • Try to undo (Cmd + Z)
  • Try to redo (Cmd + Y)

Test 2:

  • Open a document
  • From the Tools side panel, click the "Reformat" tool
  • Save (Cmd + S)
  • Try to undo (Cmd + Z)
  • Try to redo (Cmd + Y)

Can you try again using the latest build?

@ajeanmahoney
Copy link
Collaborator Author

Test 1 passes - I can undo edits that were made before a save point and edits made before 4 save points.

Test 2 fails - I cannot undo a "Reformat" even if I haven't saved. I used both Cmd + Z and selected Edit > Undo.

Note that Cmd + Y doesn't work on my system, but Cmd + Shift + Z does, which is the short cut shown for Edit > Redo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
None yet
Development

No branches or pull requests

2 participants