refactor: Refactor build_file_urls() #5886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
reviewed
Jun 27, 2023
| # As of 2022-12-14, there are 1463 Document and 3136 DocHistory records with type='draft' and rev=''. | ||
| # All of these are in the rfc state and are covered by the above cases. | ||
| log.unreachable('2022-12-14') | ||
| if doc.type_id == "draft": |
There was a problem hiding this comment.
It recreates the original logic (unless I blew it). This else block now handles what used to be the short-circuit for non-draft/non-rfc documents. This if causes it to also log the unreachable should a draft without a rev get through.
There was a problem hiding this comment.
Ah - its because of the refactor of the original L1003-1004. Got it.
There was a problem hiding this comment.
Yes, that seemed just begging to skew out of sync with the if cases and turn into a bug later.
rjsparks
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.