feat: Add list of sub-groups to group's "about" page #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
reviewed
Mar 30, 2023
| @@ -401,8 +404,38 @@ <h2 class="mt-3"> | |||
| </p> | |||
| {% endif %} | |||
| {% endif %} | |||
| {% if subgroups %} | |||
| <h2 class="mt-4"> | |||
| Subgroups under {{ group.acronym|upper }} | |||
There was a problem hiding this comment.
Normal people would expect to just see "Groups under ART" not "Subgroups under ART"
There was a problem hiding this comment.
And consider "Group in ART" rather then "under"
Codecov Report
@@ Coverage Diff @@
## main #5450 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 284 284
Lines 39503 39525 +22
=======================================
+ Hits 35079 35102 +23
+ Misses 4424 4423 -1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Mar 31, 2023
|
intentionally squashing this into main rather than feat/postgres |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5441