From 283be665dd34b9340deb82efd6c750b13db3d73a Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Fri, 17 Mar 2023 17:13:12 +0200 Subject: [PATCH 1/3] fix: Add reviewer name to review assignment summary Fixes #5360 --- ietf/templates/doc/review_assignment_summary.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ietf/templates/doc/review_assignment_summary.html b/ietf/templates/doc/review_assignment_summary.html index 29781fcad9..b9ed85851d 100644 --- a/ietf/templates/doc/review_assignment_summary.html +++ b/ietf/templates/doc/review_assignment_summary.html @@ -7,7 +7,8 @@ {% if review_assignment.review_request.doc.name != current_doc_name %} {{ review_assignment.review_request.doc.name }} {% endif %} - -{{ review_assignment.reviewed_rev }}){% endif %} + -{{ review_assignment.reviewed_rev }}){% endif %} + by {{ review_assignment.reviewer.person.name }} {% if review_assignment.state_id == "part-completed" %} Partially completed {% endif %} From f30fd49448b380d53298a9865e8c9b2976207b13 Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Mon, 20 Mar 2023 13:16:24 +0200 Subject: [PATCH 2/3] Address code review --- ietf/templates/doc/review_assignment_summary.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/templates/doc/review_assignment_summary.html b/ietf/templates/doc/review_assignment_summary.html index b9ed85851d..5f45af9bad 100644 --- a/ietf/templates/doc/review_assignment_summary.html +++ b/ietf/templates/doc/review_assignment_summary.html @@ -8,7 +8,7 @@ {{ review_assignment.review_request.doc.name }} {% endif %} -{{ review_assignment.reviewed_rev }}){% endif %} - by {{ review_assignment.reviewer.person.name }} + by {{ review_assignment.reviewer.person.plain_name() }} {% if review_assignment.state_id == "part-completed" %} Partially completed {% endif %} From e852b471663711a39196f459a36c532841e068a4 Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Mon, 20 Mar 2023 13:59:41 +0200 Subject: [PATCH 3/3] Fix test harder --- ietf/templates/doc/review_assignment_summary.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ietf/templates/doc/review_assignment_summary.html b/ietf/templates/doc/review_assignment_summary.html index 5f45af9bad..4685bdf1cd 100644 --- a/ietf/templates/doc/review_assignment_summary.html +++ b/ietf/templates/doc/review_assignment_summary.html @@ -8,7 +8,7 @@ {{ review_assignment.review_request.doc.name }} {% endif %} -{{ review_assignment.reviewed_rev }}){% endif %} - by {{ review_assignment.reviewer.person.plain_name() }} + by {{ review_assignment.reviewer.person.plain_name }} {% if review_assignment.state_id == "part-completed" %} Partially completed {% endif %}