Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move IETF Activity reports from external text based to HTML pages #5180

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

rpcross
Copy link
Collaborator

@rpcross rpcross commented Feb 22, 2023

No description provided.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are inline. I think there's a mustfix fencepost error on the end date handling plus some smaller stuff.

ietf/iesg/views.py Outdated Show resolved Hide resolved
ietf/iesg/views.py Outdated Show resolved Hide resolved
ietf/iesg/views.py Outdated Show resolved Hide resolved
ietf/iesg/views.py Outdated Show resolved Hide resolved
ietf/iesg/views.py Outdated Show resolved Hide resolved
ietf/iesg/views.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #5180 (9d76281) into main (ce374ac) will increase coverage by 0.02%.
The diff coverage is 85.29%.

@@            Coverage Diff             @@
##             main    #5180      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.02%     
==========================================
  Files         295      294       -1     
  Lines       40110    40087      -23     
==========================================
- Hits        35516    35505      -11     
+ Misses       4594     4582      -12     
Impacted Files Coverage Δ
ietf/iesg/urls.py 100.00% <ø> (ø)
ietf/meeting/urls.py 81.25% <ø> (ø)
ietf/meeting/views.py 91.13% <80.00%> (+0.27%) ⬆️
ietf/iesg/views.py 92.53% <85.18%> (-0.71%) ⬇️
ietf/secr/proceedings/proc_utils.py 86.33% <100.00%> (ø)
ietf/utils/fields.py 91.75% <100.00%> (ø)
ietf/nomcom/utils.py 91.30% <0.00%> (-0.25%) ⬇️
ietf/meeting/helpers.py 89.84% <0.00%> (-0.07%) ⬇️
ietf/person/models.py 91.91% <0.00%> (ø)
ietf/doc/views_search.py 89.25% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rpcross rpcross closed this Feb 24, 2023
@rjsparks rjsparks reopened this Feb 24, 2023
ietf/iesg/tests.py Show resolved Hide resolved
ietf/meeting/tests_views.py Show resolved Hide resolved
ietf/meeting/tests_views.py Show resolved Hide resolved
ietf/templates/meeting/activity_report.html Outdated Show resolved Hide resolved
@rjsparks rjsparks merged commit e469add into ietf-tools:main Feb 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants