Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort rooms by ascending capacity in schedule editor #5178

Merged

Conversation

jennifer-richards
Copy link
Member

Orders rooms on the schedule editor by ascending, not descending, capacity. This was switched to descending in #4653 but @flynnliz requested the original order.

(This is not a revert of #4653, though. That PR also made capacity the highest priority factor in room ordering, which is kept here.)

@jennifer-richards jennifer-richards marked this pull request as ready for review February 21, 2023 15:40
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #5178 (90700da) into main (f9c2376) will decrease coverage by 0.01%.
The diff coverage is 90.27%.

@@            Coverage Diff             @@
##             main    #5178      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         295      295              
  Lines       40046    40050       +4     
==========================================
+ Hits        35458    35460       +2     
- Misses       4588     4590       +2     
Impacted Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/doc/views_doc.py 91.53% <ø> (+0.15%) ⬆️
ietf/meeting/views.py 90.85% <ø> (ø)
ietf/api/views.py 89.44% <89.55%> (-0.03%) ⬇️
ietf/api/urls.py 100.00% <100.00%> (ø)
ietf/sync/discrepancies.py 100.00% <100.00%> (ø)
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 5060134 into ietf-tools:main Feb 21, 2023
@jennifer-richards jennifer-richards deleted the jennifer/small-rooms-first branch February 21, 2023 17:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants