-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve links to meeting tools from group pages #5130
Merged
rjsparks
merged 11 commits into
ietf-tools:main
from
painless-security:jennifer/group-meetecho
Feb 11, 2023
Merged
feat: Improve links to meeting tools from group pages #5130
rjsparks
merged 11 commits into
ietf-tools:main
from
painless-security:jennifer/group-meetecho
Feb 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
reviewed
Feb 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #5130 +/- ##
==========================================
+ Coverage 88.50% 88.51% +0.01%
==========================================
Files 295 295
Lines 40015 40018 +3
==========================================
+ Hits 35415 35423 +8
+ Misses 4600 4595 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rjsparks
approved these changes
Feb 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4738. Fixes both views mentioned in the ticket.
On the group meeting page (
/wg/oauth/meetings
), the session buttons were included for each entry, but thesession_buttons_include.html
template required thatnow
be set in the rendering context. To fix this, I've created a template tag that allows a template to gettimezone.now()
with{% get_now as now %}
instead of relying on the view to pass it in.For the meeting session page (
/meeting/115/session/oauth
), I've added a block for each session that shows the same links generated by thesession_buttons_include.html
, excluding a few that are redundant against what's already present. I've also updated this to use theget_now
tag.