Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve links to meeting tools from group pages #5130

Merged
merged 11 commits into from
Feb 11, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #4738. Fixes both views mentioned in the ticket.

On the group meeting page (/wg/oauth/meetings), the session buttons were included for each entry, but the session_buttons_include.html template required that now be set in the rendering context. To fix this, I've created a template tag that allows a template to get timezone.now() with {% get_now as now %} instead of relying on the view to pass it in.

For the meeting session page (/meeting/115/session/oauth), I've added a block for each session that shows the same links generated by the session_buttons_include.html, excluding a few that are redundant against what's already present. I've also updated this to use the get_now tag.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #5130 (7461ce5) into main (e280b25) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5130      +/-   ##
==========================================
+ Coverage   88.50%   88.51%   +0.01%     
==========================================
  Files         295      295              
  Lines       40015    40018       +3     
==========================================
+ Hits        35415    35423       +8     
+ Misses       4600     4595       -5     
Impacted Files Coverage Δ
ietf/ietfauth/utils.py 92.85% <ø> (ø)
ietf/meeting/views.py 90.70% <ø> (ø)
ietf/context_processors.py 68.96% <100.00%> (+3.58%) ⬆️
ietf/secr/sreq/views.py 91.16% <100.00%> (ø)
ietf/utils/text.py 85.97% <0.00%> (-0.61%) ⬇️
ietf/nomcom/utils.py 91.30% <0.00%> (-0.25%) ⬇️
ietf/doc/views_search.py 88.81% <0.00%> (ø)
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️
ietf/utils/templatetags/textfilters.py 100.00% <0.00%> (+14.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rjsparks rjsparks merged commit 6c31c73 into ietf-tools:main Feb 11, 2023
@jennifer-richards jennifer-richards deleted the jennifer/group-meetecho branch February 12, 2023 03:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join meetecho tool from meeting pages
2 participants