fix: use Internet-Draft more consistently across the UI

[larseggert]

Fixes #4818

[rjsparks]

There's enough moving here that this deserves multiple reviews. I'm requesting one from Jennifer as well.

[jennifer-richards]

Did not find anything else alarming, but a couple comments inline.

[larseggert]

I think I need some help with the migrations - see CI errors.

[rjsparks]

Not sure how you built these migrations - what you have at 0031 should have been in the review app and what you have at 0032 is a no-op?
In any case, here's the correction (which I'll push to your branch momentarily):

dev ➜ /workspace$ ietf/manage.py showmigrations | grep "\[ "
 [ ] 0031_id_term_2
 [ ] 0030_id_term_1
 [ ] 0032_id_term
dev ➜ /workspace$ ls ietf/person/migrations/003*py
0030_id_term_1.py  0031_id_term_2.py  0032_id_term.py    
dev ➜ /workspace$ rm ietf/person/migrations/003*py
dev ➜ /workspace$ ietf/manage.py makemigrations --name id_term
Migrations for 'person':
  ietf/person/migrations/0030_id_term.py
    - Alter field origin on email
    - Alter field origin on historicalemail
    - Alter field name_from_draft on historicalperson
    - Alter field name_from_draft on person
Migrations for 'review':
  ietf/review/migrations/0031_id_term.py
    - Alter field filter_re on historicalreviewersettings
    - Alter field filter_re on reviewersettings
dev ➜ /workspace$ ietf/manage.py migrate
Operations to perform:
  Apply all migrations: admin, auth, community, contenttypes, dbtemplate, django_celery_beat, doc, group, ipr, liaisons, mailinglists, mailtrigger, meeting, message, name, nomcom, oidc_provider, person, proceedings, review, sessions, sites, stats, submit, tastypie, utils
Running migrations:
  Applying person.0030_id_term... OK
  Applying review.0031_id_term... OK

It is nothing but coincidence that these are numbered 0030 and 0031 - it just turns out that's where the counters were in the respective apps.

[codecov]

Codecov Report

Merging #5104 (c2de2a9) into main (e280b25) will increase coverage by 0.01%.
The diff coverage is 68.25%.

@@            Coverage Diff             @@
##             main    #5104      +/-   ##
==========================================
+ Coverage   88.50%   88.51%   +0.01%     
==========================================
  Files         295      295              
  Lines       40015    40015              
==========================================
+ Hits        35415    35420       +5     
+ Misses       4600     4595       -5     

Impacted Files	Coverage Δ
ietf/doc/expire.py	95.31% <ø> (ø)
ietf/doc/views_ballot.py	92.86% <ø> (ø)
ietf/idindex/index.py	95.05% <ø> (ø)
ietf/ipr/utils.py	53.96% <0.00%> (ø)
ietf/review/models.py	91.91% <ø> (ø)
ietf/stats/views.py	93.10% <ø> (ø)
ietf/utils/draft.py	71.75% <0.00%> (ø)
ietf/doc/views_draft.py	91.94% <25.00%> (ø)
ietf/submit/forms.py	82.74% <37.50%> (ø)
ietf/submit/views.py	81.45% <50.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.