Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Need to linkify during Markdown rendering #5066

Merged
merged 9 commits into from
Feb 11, 2023

Conversation

larseggert
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #5066 (0f2427e) into main (bfe25fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5066      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         296      296              
  Lines       40018    40029      +11     
==========================================
+ Hits        35416    35423       +7     
- Misses       4602     4606       +4     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.70% <100.00%> (+<0.01%) ⬆️
ietf/utils/markdown.py 100.00% <100.00%> (ø)
ietf/nomcom/utils.py 91.54% <0.00%> (-0.49%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ietf/utils/markdown.py Outdated Show resolved Hide resolved
@rjsparks
Copy link
Member

rjsparks commented Feb 2, 2023

Is there a test that exercises this config change to make sure it does what we want, and would let us know if something later breaks it?

@larseggert
Copy link
Collaborator Author

Let me think about that.

@larseggert
Copy link
Collaborator Author

@rjsparks added a test.

@rjsparks rjsparks merged commit ac0b9ae into ietf-tools:main Feb 11, 2023
@larseggert larseggert deleted the fix-markdown-linkify branch February 15, 2023 07:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants