Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sort agenda editor rows by room size first #5043

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #4377.

This tends to split the display into more "room groups" because rooms with identical timeslot arrangements are no longer neighbors. As a result, the editor takes up a bit more vertical space with timeslot label rows. I don't think that's a major problem, though - there were already many more room groups than ideal due to many or most rooms having unique timeslot arrangements outside the core meeting days/hours.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #5043 (700e9c4) into main (570bd14) will decrease coverage by 0.01%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main    #5043      +/-   ##
==========================================
- Coverage   88.47%   88.47%   -0.01%     
==========================================
  Files         296      296              
  Lines       39818    39856      +38     
==========================================
+ Hits        35230    35262      +32     
- Misses       4588     4594       +6     
Impacted Files Coverage Δ
ietf/doc/views_draft.py 91.79% <50.00%> (-0.17%) ⬇️
ietf/meeting/views.py 90.69% <98.00%> (+0.12%) ⬆️
ietf/doc/views_doc.py 91.17% <100.00%> (ø)
ietf/iesg/agenda.py 92.06% <100.00%> (+0.06%) ⬆️
ietf/utils/text.py 86.58% <100.00%> (+0.60%) ⬆️
ietf/meeting/templatetags/proceedings_filters.py 88.23% <0.00%> (-5.89%) ⬇️
ietf/meeting/models.py 85.91% <0.00%> (-0.59%) ⬇️
ietf/secr/areas/views.py 37.66% <0.00%> (-0.50%) ⬇️
ietf/group/models.py 92.30% <0.00%> (-0.37%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennifer-richards jennifer-richards changed the title Jennifer/room sorting fix: Sort agenda editor rows by room size first Jan 27, 2023
@rjsparks rjsparks merged commit 8378771 into ietf-tools:main Jan 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
@jennifer-richards jennifer-richards deleted the jennifer/room-sorting branch February 1, 2023 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort rooms by size in the schedule editor
2 participants