Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show links for more session types on the agenda #5038

Merged
merged 4 commits into from
Jan 27, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #4745

Adds buttons based on the session links for most 'other' type sessions. Excludes them from sessions whose purpose is admin, closed_meeting, officehours, or social.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #5038 (d599de2) into main (570bd14) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main    #5038      +/-   ##
==========================================
- Coverage   88.47%   88.46%   -0.02%     
==========================================
  Files         296      296              
  Lines       39818    39855      +37     
==========================================
+ Hits        35230    35258      +28     
- Misses       4588     4597       +9     
Impacted Files Coverage Δ
ietf/doc/views_draft.py 91.79% <50.00%> (-0.17%) ⬇️
ietf/meeting/views.py 90.69% <98.00%> (+0.12%) ⬆️
ietf/doc/views_doc.py 91.17% <100.00%> (ø)
ietf/iesg/agenda.py 92.06% <100.00%> (+0.06%) ⬆️
ietf/utils/text.py 86.58% <100.00%> (+0.60%) ⬆️
ietf/meeting/templatetags/proceedings_filters.py 88.23% <0.00%> (-5.89%) ⬇️
ietf/meeting/models.py 85.91% <0.00%> (-0.59%) ⬇️
ietf/group/models.py 92.30% <0.00%> (-0.37%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennifer-richards jennifer-richards marked this pull request as draft January 26, 2023 21:22
@jennifer-richards jennifer-richards marked this pull request as ready for review January 26, 2023 21:46
@rjsparks rjsparks merged commit 185c4d5 into ietf-tools:main Jan 27, 2023
@jennifer-richards jennifer-richards deleted the jennifer/tix4745 branch January 27, 2023 20:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to meetecho aren't appearing for some sessions of the ietf group
3 participants