Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify tests and comply with StandardJS style #5026

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

jennifer-richards
Copy link
Member

Use === instead of ==, except where it's used to match both null and undefined. (I think just null is enough because both cookies.get() and Storage.getItem() return null when they have no data, but no harm in being liberal.)

@larseggert may want to look to be sure I didn't break this, but I think it's equivalent.

Use === instead of ==, except where it's used to match both null and
undefined.
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #5026 (46c5691) into main (570bd14) will decrease coverage by 0.03%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##             main    #5026      +/-   ##
==========================================
- Coverage   88.47%   88.45%   -0.03%     
==========================================
  Files         296      296              
  Lines       39818    39852      +34     
==========================================
+ Hits        35230    35250      +20     
- Misses       4588     4602      +14     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.69% <98.00%> (+0.12%) ⬆️
ietf/iesg/agenda.py 92.06% <100.00%> (+0.06%) ⬆️
ietf/utils/text.py 86.58% <100.00%> (+0.60%) ⬆️
ietf/meeting/templatetags/proceedings_filters.py 88.23% <0.00%> (-5.89%) ⬇️
ietf/submit/checkers.py 73.60% <0.00%> (-3.05%) ⬇️
ietf/meeting/models.py 85.91% <0.00%> (-0.59%) ⬇️
ietf/group/models.py 92.30% <0.00%> (-0.37%) ⬇️
ietf/utils/draft.py 71.54% <0.00%> (-0.21%) ⬇️
ietf/doc/views_search.py 89.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ietf/static/js/document_html.js Outdated Show resolved Hide resolved
@rjsparks rjsparks merged commit 040af97 into ietf-tools:main Jan 25, 2023
@jennifer-richards jennifer-richards deleted the jennifer/jsnitpick branch January 26, 2023 21:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants