Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use idnits3 for post submission nits check #8169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kesara
Copy link
Member

@kesara kesara commented Nov 6, 2024

Fixes #8107

@@ -2996,6 +2996,24 @@ def test_raw_id(self):
self.should_succeed(dict(name=draft.name, rev='00',ext='txt'))
self.should_404(dict(name=draft.name, rev='00',ext='html'))

@override_settings(IDNITS3_BASE_URL="https://example.org/idnits3")
def test_nits_url(self):
draft = WgDraftFactory(name="draft-ietf-moon-test",rev="01", create_revisions=range(0,2))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment as to why you're setting up this particular arrangement of revisions would be helpful

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, meant to request changes for the comment (code itself looks fine)

@rjsparks
Copy link
Member

rjsparks commented Nov 7, 2024

If someone really wanted the v2 nits, can they get back to them quickly?

@rjsparks
Copy link
Member

rjsparks commented Nov 14, 2024

Nudge:

If someone really wanted the v2 nits, can they get back to them quickly?

@kesara
Copy link
Member Author

kesara commented Nov 14, 2024

If someone really wanted the v2 nits, can they get back to them quickly?

No there are no quick links for that. Author tools just shows the output from idnits.

@rjsparks
Copy link
Member

so maybe instead of replacing the idnits2 button, we provide both idnits2 and idnits3 buttons until idnits3 becomes the thing in the submit path?

@cabo
Copy link
Collaborator

cabo commented Nov 16, 2024

Where can I find idnits3?
https://github.com/ietf-tools/idnits does not appear to be in a useful state.

@kesara
Copy link
Member Author

kesara commented Nov 16, 2024

Where can I find idnits3? https://github.com/ietf-tools/idnits does not appear to be in a useful state.

@cabo, You can install with npm 1 or use idnits3 on Auhtor Tools.

Footnotes

  1. https://github.com/ietf-tools/idnits?tab=readme-ov-file#installation

@kesara
Copy link
Member Author

kesara commented Nov 16, 2024

so maybe instead of replacing the idnits2 button, we provide both idnits2 and idnits3 buttons until idnits3 becomes the thing in the submit path?

One of the motivations of this change is to stop unnecessary idnits2 checks because this makes a call to datatracker which seems slow and could affect datatracker performance.

@cabo
Copy link
Collaborator

cabo commented Nov 16, 2024

@cabo, You can install with npm 1 or use idnits3 on Auhtor Tools.

OK, I have that, so "3.0.0-alpha.36" appears to be the most recent revision.
That is not very useful.

https://author-tools.ietf.org/api/idnits3?url=https://www.ietf.org/archive/id/draft-ietf-cbor-cddl-more-control-07.xml
https://mailarchive.ietf.org/arch/msg/last-call/IM2SIo26RzBq0tO0lG5JETyGGNo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nits check URL
4 participants