-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use idnits3 for post submission nits check #8169
base: main
Are you sure you want to change the base?
Conversation
@@ -2996,6 +2996,24 @@ def test_raw_id(self): | |||
self.should_succeed(dict(name=draft.name, rev='00',ext='txt')) | |||
self.should_404(dict(name=draft.name, rev='00',ext='html')) | |||
|
|||
@override_settings(IDNITS3_BASE_URL="https://example.org/idnits3") | |||
def test_nits_url(self): | |||
draft = WgDraftFactory(name="draft-ietf-moon-test",rev="01", create_revisions=range(0,2)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment as to why you're setting up this particular arrangement of revisions would be helpful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, meant to request changes for the comment (code itself looks fine)
If someone really wanted the v2 nits, can they get back to them quickly? |
Nudge:
|
No there are no quick links for that. Author tools just shows the output from idnits. |
so maybe instead of replacing the idnits2 button, we provide both idnits2 and idnits3 buttons until idnits3 becomes the thing in the submit path? |
Where can I find idnits3? |
@cabo, You can install with Footnotes |
One of the motivations of this change is to stop unnecessary idnits2 checks because this makes a call to datatracker which seems slow and could affect datatracker performance. |
OK, I have that, so "3.0.0-alpha.36" appears to be the most recent revision. https://author-tools.ietf.org/api/idnits3?url=https://www.ietf.org/archive/id/draft-ietf-cbor-cddl-more-control-07.xml |
Fixes #8107