Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipr email ingestion always reports success #7563

Closed
1 task done
jennifer-richards opened this issue Jun 19, 2024 · 0 comments · Fixed by #7584
Closed
1 task done

ipr email ingestion always reports success #7563

jennifer-richards opened this issue Jun 19, 2024 · 0 comments · Fixed by #7584
Assignees
Labels

Comments

@jennifer-richards
Copy link
Member

Describe the issue

The IPR response email ingester connected to the ingest_email api view exits cleanly whether or not it actually accepted the email. It should instead raise an EmailIngestionError() (i.e., with email_body=None, the default) if it did not accept the message. This will cause it to indicate a bad_msg failure but not send an alert mail to the admins.

In the meantime, any mail sent to the IPR response address will appear to be accepted, even if it was dropped. This is not ideal, but the rate of non-SPAM sent to that address is low enough that it's not an emergency.

Code of Conduct

@jennifer-richards jennifer-richards self-assigned this Jun 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant