You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A pair of log.assertion() guards in AgendaFilterOrganizer._group_filter_headings() sound an alarm if the number of groups (or group parents) does not match the number of distinct acronyms. The intention is to alert the admins of a collision between group acronyms. However, the group list is generated using Session.group_at_the_time(), which can return either a Group or a GroupHistory. If a group has sessions both before and after a change, then it appears in the group list as both a Group and a GroupHistory and is double-counted, causing the assertion to fail.
This occurred on 2023-11-21 because a change in the chairs for the ntfsv4 group occurred on the day of an interim meeting for the group. Visits to the upcoming meeting page triggered the assertion.
This cannot affect an IETF meeting because all sessions in a meeting use the meeting start to calculate their group_at_the_time so will always agree on either a Group or a GroupHistory.
To fix this, the assertion logic needs to recognize when a GroupHistory and a Group refer to the same group.
Describe the issue
A pair of
log.assertion()
guards inAgendaFilterOrganizer._group_filter_headings()
sound an alarm if the number of groups (or group parents) does not match the number of distinct acronyms. The intention is to alert the admins of a collision between group acronyms. However, the group list is generated usingSession.group_at_the_time()
, which can return either aGroup
or aGroupHistory
. If a group has sessions both before and after a change, then it appears in the group list as both aGroup
and aGroupHistory
and is double-counted, causing the assertion to fail.This occurred on 2023-11-21 because a change in the chairs for the ntfsv4 group occurred on the day of an interim meeting for the group. Visits to the upcoming meeting page triggered the assertion.
This cannot affect an IETF meeting because all sessions in a meeting use the meeting start to calculate their
group_at_the_time
so will always agree on either aGroup
or aGroupHistory
.To fix this, the assertion logic needs to recognize when a
GroupHistory
and aGroup
refer to the same group.Code of Conduct
The text was updated successfully, but these errors were encountered: