Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertions in AgendaFilterOrganizer do not account for GroupHistory #6683

Closed
1 task done
jennifer-richards opened this issue Nov 22, 2023 · 0 comments · Fixed by #6701
Closed
1 task done

Assertions in AgendaFilterOrganizer do not account for GroupHistory #6683

jennifer-richards opened this issue Nov 22, 2023 · 0 comments · Fixed by #6701
Assignees

Comments

@jennifer-richards
Copy link
Member

Describe the issue

A pair of log.assertion() guards in AgendaFilterOrganizer._group_filter_headings() sound an alarm if the number of groups (or group parents) does not match the number of distinct acronyms. The intention is to alert the admins of a collision between group acronyms. However, the group list is generated using Session.group_at_the_time(), which can return either a Group or a GroupHistory. If a group has sessions both before and after a change, then it appears in the group list as both a Group and a GroupHistory and is double-counted, causing the assertion to fail.

This occurred on 2023-11-21 because a change in the chairs for the ntfsv4 group occurred on the day of an interim meeting for the group. Visits to the upcoming meeting page triggered the assertion.

This cannot affect an IETF meeting because all sessions in a meeting use the meeting start to calculate their group_at_the_time so will always agree on either a Group or a GroupHistory.

To fix this, the assertion logic needs to recognize when a GroupHistory and a Group refer to the same group.

Code of Conduct

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants