Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pill colours affecting readability #6116

Closed
1 task done
fiestajetsam opened this issue Aug 10, 2023 · 6 comments
Closed
1 task done

Pill colours affecting readability #6116

fiestajetsam opened this issue Aug 10, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@fiestajetsam
Copy link

Describe the issue

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/118.0

Pills without any specific colour (falling back to grey) blend in too well with the alternating colours of tables making the text difficult to read, for example:
image

Possibly related to #6112 ?

Code of Conduct

@fiestajetsam fiestajetsam added the bug Something isn't working label Aug 10, 2023
@larseggert
Copy link
Collaborator

Which page/URL is that on?

@larseggert
Copy link
Collaborator

Also, this is possibly already fixed on the feat/dark-mode branch.

@fiestajetsam
Copy link
Author

@larseggert the above screenshot is on the "My Reviews" page.

@larseggert
Copy link
Collaborator

Thanks! feat/dark-mode should have the fix already.

@larseggert larseggert self-assigned this Aug 10, 2023
@rjsparks
Copy link
Member

Dark-mode was released today - @fiestajetsam, does it address your concern?

@rjsparks
Copy link
Member

I'm closing this - my inspection says that it addresses the issue - if the fix turns out to be insufficient, please reopen.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants