Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review person and doc search apis for abuse possibilities #6008

Open
1 task done
richsalz opened this issue Jul 22, 2023 · 1 comment
Open
1 task done

Review person and doc search apis for abuse possibilities #6008

richsalz opened this issue Jul 22, 2023 · 1 comment

Comments

@richsalz
Copy link
Collaborator

Description

If you type /person/@ as a datatracker URL, it will apparently end up returning if #6007 is merged. Or /person/mark
That PR changed "exact match" to "case insensitive contains" which means that the found more than one name is much more likely to happen. (The API seems like it always used __icontains so this is maybe not a new hole)

This also opens the datatracker to spam harvesters. I think we should do the following for both API and HTML/web

  • If just one match is found, return or display it
  • If multiple matches are found, just return/display the list (I prefer not to linkify them; see above)
  • Limit the number of rows returned via SQL

Code of Conduct

@rjsparks
Copy link
Member

6007 was change to iexact. We should review the endpoints meant for the person/document choosing form widgets to see how abuse-able they are.

@rjsparks rjsparks changed the title Multiple search can be a DoS attack Review person and doc search apis for abuse possibilities Jul 25, 2023
@richsalz richsalz mentioned this issue Jul 25, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants