Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wording change on /secr/sreq #5163

Closed
1 task done
jennifer-richards opened this issue Feb 16, 2023 · 2 comments · Fixed by #5169
Closed
1 task done

Wording change on /secr/sreq #5163

jennifer-richards opened this issue Feb 16, 2023 · 2 comments · Fixed by #5169
Assignees
@larseggert
Labels
component: secr/sreq/ enhancement New feature or request medium

Comments

@jennifer-richards
Copy link
Member

Description

Requested by @flynnliz, please change, "You should not include the Area Directors; they will be added automatically," to something like, "You should not include your Area Director; the tool accounts for their conflicts separately," to avoid giving the impression that the AD's name will actually appear in the field.

People seem to add the AD anyway. Would be nice to prevent this because even the rephrasing may not discourage it enough.

Code of Conduct
@cabo
Copy link
Collaborator

cabo commented Feb 16, 2023

(Don't accept data you don't want to process...)

@rjsparks
Copy link
Member

See #3890

larseggert added a commit to larseggert/datatracker that referenced this issue Feb 17, 2023
@larseggert
fix: Prevent ADs and chairs from added to bethere constraint
f9072f7 
Fixes ietf-tools#5163 and ietf-tools#3890
@larseggert larseggert mentioned this issue Feb 17, 2023
Merged
@larseggert larseggert self-assigned this Feb 17, 2023
rjsparks added a commit that referenced this issue Feb 21, 2023
@larseggert @rjsparks @jennifer-richards
fix: Prevent ADs and chairs from being added to bethere constraint (#…
cb7abbc 
…5169)

* fix: Prevent ADs and chairs from added to `bethere` constraint

Fixes #5163 and #3890

* Fix tests and change from "people" to "participants", to hopefully make it
clearer it's not ADs and chairs.

* Rewrap

* Update ietf/secr/sreq/forms.py

Co-authored-by: Robert Sparks <[email protected]>

---------

Co-authored-by: Robert Sparks <[email protected]>
Co-authored-by: Jennifer Richards <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larseggert larseggert

Labels
component: secr/sreq/ enhancement New feature or request medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent ADs and chairs from being added to bethere constraint larseggert/datatracker
4 participants
@cabo @larseggert @rjsparks @jennifer-richards