Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential new datetime issues #4976

Closed
1 task done
larseggert opened this issue Jan 12, 2023 · 3 comments · Fixed by #5020
Closed
1 task done

Potential new datetime issues #4976

larseggert opened this issue Jan 12, 2023 · 3 comments · Fixed by #5020
Assignees
@jennifer-richards
Labels
accepted bug Something isn't working component: doc/ medium

Comments

@larseggert
Copy link
Collaborator

larseggert commented Jan 12, 2023 •
edited
Loading

Describe the issue

See CI failures

There is also this one, which is different but possibly related:

CC @jennifer-richards

Code of Conduct
@larseggert larseggert added the bug Something isn't working label Jan 12, 2023
@larseggert larseggert changed the title Potential new datetime issue Potential new datetime issues Jan 12, 2023
@rjsparks
Copy link
Member

I didn't encounter these during the recent release builds - are they transient or OBE?

@larseggert
Copy link
Collaborator Author

larseggert commented Jan 23, 2023 •
edited
Loading

Me neither. Transient.

@jennifer-richards
Copy link
Member

I think it's probably real, the test is using a UTC date to compare with the deadline computed in DEADLINE_TZINFO (still PST8PDT). I'd have thought there was enough fuzz in the comparison, but it's easier to fix this than think super hard about that. Will do that now.

@jennifer-richards jennifer-richards self-assigned this Jan 23, 2023
This was referenced Jan 23, 2023
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-richards jennifer-richards

Labels
accepted bug Something isn't working component: doc/ medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use settings.TIME_ZONE when looking up telechat agenda_date() painless-security/datatracker
3 participants
@larseggert @rjsparks @jennifer-richards