update timestamp for meeting agendas seem incorrect

[ghwood]

What happened?

The last updated timestamp seems to be too far in the past.

It also should use either the user's local timezone or UTC.

Attached is a screenshot of https://datatracker.ietf.org/meeting/114/agenda/ taken on 2022-04-20 at 9:45 in a EDT.

What browser(s) are you seeing the problem on?

Safari

Code of Conduct

• I agree to follow the IETF's Code of Conduct

[jennifer-richards]

I believe the 1970-01-01 date is because there is not yet an agenda for IETF 114. This should probably be indicated instead of displaying a bogus timestamp. For https://datatracker.ietf.org/meeting/113/agenda/, the date shows as "Updated: 2022-03-23 at 7:52:27 (PDT)" which is plausible (but still fixed to US Pacific time rather than something sensible for the user or meeting).

[jennifer-richards]

Poking, there's an attempt to hide the "updated" indicator if meeting.updated() is not defined. Unfortunately, the updated() method returns 1970-01-01T00:00:00 rather thanNone in that situation, which defies the effort.

[rjsparks]

I think if you get back exactly that datetime, you an just say "it means this wasn't updated".
What will be returned when we become TZ aware?

[jennifer-richards]

It localizes to PRODUCTION_TIMEZONE, so won't change due to the USE_TZ settings. It'd be nice to change it to be explicitly UTC instead of something that depends on settings.py if we want to use a magic number.

We could instead/also just say that anything before [date after Jan 2, 1970 and before plausible update time] is too long ago to be plausible. That'd avoid depending on a particular time zone for the view.

[microamp]

Looks like there are some guards in place now.

if (!updatedDatetime.isValid || updatedDatetime < DateTime.fromISO('1980-01-01')) {
  return false
}

(in client/agenda/Agenda.vue)

It's hard to know when the change was made. The Git history only goes back to Feb 2024 if I'm reading it correctly.

I'll spend some time testing the code at the code sprint tomorrow.

[microamp]

It appears to me that when /api/meeting/114/agenda-data returns the default updated time, i.e. 1970-01-01T00:00:00Z, e.g.

{
    "meeting": {
        "number": "114",
        "city": "Philadelphia",
        "startDate": "2022-07-23",
        "endDate": "2022-07-29",
        "updated": "1970-01-01T00:00:00Z",
        "timezone": "America/New_York",
        "infoNote": "Please see the <a href=\"https://datatracker.ietf.org/meeting/114/proceedings\">IETF 114 Proceedings</a> for further records of this meeting.",
        "warningNote": ""
    },
    // ...
}

it correctly hides the Updated element in the UI.

So, I believe the bug has been fixed.

However, we may also want to apply the same filter to the plain text page for consistency.

^agenda(?P<utc>-utc)?(?P<ext>\.txt|\.csv)$

e.g. /meeting/114/agenda.txt

P.S. agenda.csv does not use updated, only agenda.txt does.

[rjsparks]

However, we may also want to apply the same filter to the plain text page for consistency.

Yes - that sounds good.