Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apikey/del should not offer already disabled api keys #3441

Closed
ietf-svn-bot opened this issue Oct 22, 2021 · 1 comment · Fixed by #5262
Closed

apikey/del should not offer already disabled api keys #3441

ietf-svn-bot opened this issue Oct 22, 2021 · 1 comment · Fixed by #5262
Assignees
@larseggert
Labels
accepted component: person/ medium

Comments

@ietf-svn-bot
Copy link

type_defect | by [email protected]

The issue here is the when a user tries to disable an API key from /accounts/apikey

They are taken to view where all the API keys (including disabled ones) are listed in a dropdown.

If the user selects an already disabled API key...

The view should be modified to not offer disabled keys.

Issue migrated from trac:3441 at 2022-03-04 09:17:36 +0000
@ietf-svn-bot
Copy link
Author

@[email protected] changed status from new to accepted

@larseggert larseggert self-assigned this Mar 2, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Mar 2, 2023
@larseggert
fix: Don't offer already-disabled API keys for disablement
39311db 
Fixes ietf-tools#3441
@larseggert larseggert mentioned this issue Mar 2, 2023
Merged
rjsparks pushed a commit that referenced this issue Mar 2, 2023
@larseggert
fix: Don't offer already-disabled API keys for disablement (#5262)
276dd08 
* fix: Don't offer already-disabled API keys for disablement

Fixes #3441

* Remove test class
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larseggert larseggert

Labels
accepted component: person/ medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't offer already-disabled API keys for disablement larseggert/datatracker
2 participants
@larseggert @ietf-svn-bot