Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing RFC number in meta description tag #3379

Closed
ietf-svn-bot opened this issue Aug 13, 2021 · 7 comments · Fixed by #5265
Closed

Missing RFC number in meta description tag #3379

ietf-svn-bot opened this issue Aug 13, 2021 · 7 comments · Fixed by #5265
Assignees
@larseggert
Labels
accepted component: doc/ medium

Comments

@ietf-svn-bot
Copy link

ietf-svn-bot commented Aug 13, 2021 •
edited by rjsparks
Loading

type_defect | by [email protected]

On, eg, https://datatracker.ietf.org/doc/html/rfc9004, there's a tag:
<meta name="description" content="Updates for the Back-to-Back Frame Benchmark in RFC 2544 (RFC )">

Presumably the RFC number was supposed to be in parentheses? (Unsurprisingly, this seems to be true across RFCs.)

Thanks,
Alex

Issue migrated from trac:3379 at 2022-03-04 09:11:14 +0000
@ietf-svn-bot
Copy link
Author

@[email protected] changed status from new to accepted

@larseggert
Copy link
Collaborator

I think this is OBE.

@rjsparks
Copy link
Member

rjsparks commented Mar 2, 2023 •
edited
Loading

No - it 's different but it's still not right - here's what's currently there:

<meta name="description"
            
                content="Updates for the Back-to-Back Frame Benchmark in RFC 2544 (RFC 9004, May 2021"
            >

(Note that I quoted what was in the original description so that it displayed in github)

@larseggert larseggert self-assigned this Mar 2, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Mar 2, 2023
@larseggert
fix: Add missing closing brace in meta tag
54c0cb9 
Fixes ietf-tools#3379
@larseggert larseggert mentioned this issue Mar 2, 2023
Merged
@rjsparks
Copy link
Member

rjsparks commented Mar 2, 2023

Does putting the closing brace in solve the missing "Obsoleted by" and "published on" text problem?

@larseggert
Copy link
Collaborator

"Published on" is there (May 2021). Checking on "obsoleted by".

@larseggert
Copy link
Collaborator

Fixed that, too. Was also broken on the main doc page.

@rjsparks
Copy link
Member

rjsparks commented Mar 2, 2023

Something is still off. Will comment in the PR.

rjsparks pushed a commit that referenced this issue Mar 3, 2023
@larseggert
fix: Add missing closing brace in meta tag and updated/obsoleted-by i…
1d87686 
…nfo (#5265)

* fix: Add missing closing brace in meta tag

Fixes #3379

* Also fix "obsoleted by" meta information

* name -> canonical_name
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@larseggert larseggert

Labels
accepted component: doc/ medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing closing brace in meta tag and updated/obsoleted-by info larseggert/datatracker
3 participants
@larseggert @rjsparks @ietf-svn-bot