From 73968dca5f0ee2450080b585d6da162bdc870955 Mon Sep 17 00:00:00 2001 From: Robert Sparks Date: Wed, 28 Aug 2024 14:17:36 -0500 Subject: [PATCH] fix: use rsab mailtrigger for To in ballot position email (#7868) --- ietf/doc/tests_ballot.py | 3 +++ ietf/doc/views_ballot.py | 2 ++ 2 files changed, 5 insertions(+) diff --git a/ietf/doc/tests_ballot.py b/ietf/doc/tests_ballot.py index d77e2ddc98..0c99ed281a 100644 --- a/ietf/doc/tests_ballot.py +++ b/ietf/doc/tests_ballot.py @@ -230,6 +230,9 @@ def test_cannot_edit_position_as_pre_ad(self): r = self.client.post(url, dict(position="discuss", discuss="Test discuss text")) self.assertEqual(r.status_code, 403) + # N.B. This test needs to be rewritten to exercise all types of ballots (iesg, irsg, rsab) + # and test against the output of the mailtriggers instead of looking for hardcoded values + # in the To and CC results. See #7864 def test_send_ballot_comment(self): ad = Person.objects.get(user__username="ad") draft = WgDraftFactory(ad=ad,group__acronym='mars') diff --git a/ietf/doc/views_ballot.py b/ietf/doc/views_ballot.py index 8d9ab0b740..2b7faac92b 100644 --- a/ietf/doc/views_ballot.py +++ b/ietf/doc/views_ballot.py @@ -323,6 +323,8 @@ def build_position_email(balloter, doc, pos): if doc.stream_id == "irtf": addrs = gather_address_lists('irsg_ballot_saved',doc=doc) + elif doc.stream_id == "editorial": + addrs = gather_address_lists('rsab_ballot_saved',doc=doc) else: addrs = gather_address_lists('iesg_ballot_saved',doc=doc)