Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files backend: Fatal error if ACL contains user not listed in password file #107

Closed
sirockin opened this issue Oct 29, 2020 · 1 comment · Fixed by #108
Closed

Files backend: Fatal error if ACL contains user not listed in password file #107

sirockin opened this issue Oct 29, 2020 · 1 comment · Fixed by #108

Comments

@sirockin
Copy link

When using the files backend, if the ACL contains a user not listed in the password file, the plugin returns a fatal error and mosquitto shuts down:

`level=fatal msg="Backend register error: couldn't initialize files backend with error read acls: Files backend error: user user_not_in_acl
does not exist for acl at line 15."

This is different to 'standard' ACL/password behaviour for mosquitto, which silently ignores the ommission.

I would argue that this should not be a fatal error (by all means log a warning though) for the following reasons:

  1. The admin may wish to temporarily disable a user by removing their password but not want to get rid of their ACL
  2. For consistency and ease of comprehension, Files backend behaviour should mimic as closely as possible the standard Mosquitto implementation
@iegomez
Copy link
Owner

iegomez commented Oct 29, 2020

Sorry about that, @sirockin , and thanks for noticing. Already fixed in 1.2.1.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants