Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Upgrade to Bootstrap v4 #4

Closed
wolfy1339 opened this issue Sep 11, 2015 · 3 comments
Closed

Upgrade to Bootstrap v4 #4

wolfy1339 opened this issue Sep 11, 2015 · 3 comments
Labels
maybe todo

Comments

@wolfy1339
Copy link
Contributor

It would be cool to start making a new version that is based on Bootstrap 4.0.0 since it's in Alpha stage right now, so your release of m8tro-bootstrap can be released as soon as it is released.
@idleberg
Copy link
Owner

I have not decided whether I'm going to support Bootstrap 4, but if I will, I won't start before it's stable (or at least beta)

@idleberg idleberg reopened this Nov 5, 2015
@idleberg idleberg added maybe and removed maybe labels Nov 5, 2015
@wolfy1339 wolfy1339 changed the title Upgrade to v4 Alpha Upgrade to Bootstrap v4 Aug 23, 2016
@wolfy1339
Copy link
Contributor Author

wolfy1339 commented Aug 23, 2016 •
edited
Loading

Thanks! I'm looking forward to Bootstrap 4, since I plan to redo this theme from scratch, probably going in a slightly different direction. We'll see!

I have a suggestion: Is it possible to turn this into a fork of bootstrap and use their source files, and add our styles to them so we aren't duplicating classes?

@idleberg
Copy link
Owner

As I've said elsewhere, v4 will be very different from v3, since my interests have shifted. I will recreate it from scratch, with some huge differences.

Is it possible to turn this into a fork of bootstrap and use their source files, and add our styles to them so we aren't duplicating classes?

Classes are overwritten, not duplicated. Also, as of the current Bootstrap 4 alpha, customization has become even easier.

@iref iref mentioned this issue Jul 12, 2018
Merged
martin-g pushed a commit to martin-g/wicket-bootstrap that referenced this issue Jul 12, 2018
@iref @martin-g
Bootstrap4 themes (#749)
039b799 
I updated bootstrap-theme, bootswatch and material design themes to bootstrap 4.
The biggest change is that oficial bootstrap 4 does not provide `bootstrap-theme` as separate stylesheet rather we have to enable two properties in sass source and compile it. I added shell script that automates this process, similarly to scripts in other themes.

Remaining themes are in different state of migration:

* M8tro - No sign of upgrade to 4 (idleberg/m8tro-bootstrap#4)
* Vegibit - No sign of upgrade to 4
* Google - Upgrade in progress (todc/todc-bootstrap#172)

What do you think is the best approach here? Can we just delete them? Or should we wait until todc releases new version of Google theme before we merge this to upstream branch?
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
maybe todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idleberg @wolfy1339