Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: VSI Setup Boundary Condition #262

Open
birnstiel opened this issue Sep 11, 2024 · 3 comments
Open

BUG: VSI Setup Boundary Condition #262

birnstiel opened this issue Sep 11, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@birnstiel
Copy link

Describe the issue:

I think the inner radial boundary of the VSI setup is not correct (I hope I'm not being stupid again). This line:

Vc(VX3,k,j,i) = R*Omega;

defines Keplerian rotation for the ghost cells, but just above omega is initialized as Omega = 1.0 and not changed anywhere else. I think Omega can be removed and the velocity could be set as:

Vc(VX3,k,j,i) = 1.0/sqrt(R);

Error message:

No response

runtime information:

Issue is architecture independent.

@birnstiel birnstiel added the bug Something isn't working label Sep 11, 2024
@glesur
Copy link
Contributor

glesur commented Sep 16, 2024

Yes, well, there is no "perfect" boundary conditions for VSI. The one in the test suite imposes a solid body rotation, so that there is no free energy to tap into in the ghost zones, but it creates artefacts.

The best configuration is to actually add a wave-killing zone. What you propose can help, but is not full-proof, unfortunately.

@birnstiel
Copy link
Author

Ok I see. I now saw that the inner boundary is at R=1, hence this is not an issue unless the radial domain is changed.

Somewhat related question: how is the dust boundary condition defined? Does it always equal the gas boundary condition of that side & direction? I.e. if I set a boundary to outflow, it will be outflow in dust and gas while if I set it to userdef I need to define it for both dust and gas? So there is no gas=outflow while dust=userdef?

@glesur
Copy link
Contributor

glesur commented Sep 20, 2024

We have discussed the issue of boundary conditions for gas+dust mixture during the last idefix days. As of now, the boundary conditions are common to every fluid, so if it's outflow for the gas, it's outflow for the dust. This was initially to be retro-compatible with pluto.

The plan is to change that, and define boundary conditions separately for each fluid. I'll therefore keep this issue opened until this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants