Add schedule field type #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1ec5 this sounds great. I am wondering, how could this be extended / further developed into something that allows a schedule-like UI for the One additional complexity for the conditional restrictions is, that there are values like |
|
🤯 Conditional restriction syntax is a couple levels of complexity beyond schema-builder and iD right now. There isn’t even generalized support for any kind of prefix or suffix yet, e.g., openstreetmap/iD#6168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new field type
schedulefor any field that accepts the opening_hours syntax.The term “schedule” was chosen to avoid implying that it’s only for the timespan semantics in
opening_hoursas opposed to the point-in-time semantics inservice_timesorcollection_times. A basic UI for all three keys would look essentially the same, especially on native platforms that provide standard controls for this sort of thing. The differences in a more sophisticated custom UI would be minor enough that we can make the distinction in a separate property if necessary.Fixes #100.