Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Logging for missing Course/Instructor values #89

Open
ChaseC99 opened this issue Jun 1, 2021 · 1 comment
Open

Add Sentry Logging for missing Course/Instructor values #89

ChaseC99 opened this issue Jun 1, 2021 · 1 comment
Assignees
Labels
graphql graphql related items Story Point 2 Small UI Change, or bugfix. No new tests are required.

Comments

@ChaseC99
Copy link
Member

ChaseC99 commented Jun 1, 2021

We should add logging to notify us when a course id or instructor is missing from our datasets.
The log would get triggered when a grades or schedule query tries to access the cache and finds that one is missing.

@ChaseC99 ChaseC99 added graphql graphql related items Story Point 2 Small UI Change, or bugfix. No new tests are required. labels Jun 1, 2021
@ramanxg ramanxg self-assigned this Oct 14, 2021
@ramanxg ramanxg removed their assignment Oct 27, 2021
@ramanxg
Copy link
Member

ramanxg commented Oct 27, 2021

In the course_offerring type, we search our cache to find the matching information on a professor, or course, it is not always in our cache. In this case, we need to log this in Sentry. Sentry is already setup, in the project, all that has to occur is when this event occurs, we should send an event to Sentry.

This is an example of one of an instructor that is currently not in our cache:

{
  grades(instructor:"SHEPHERD, B.") {
    grade_distributions {
      course_offering {
        instructors {
          name
          ucinetid
          shortened_name
        }
      }
    }
  }
}

An example of a course not in our cache:

{
  grades(department:"CSE", number:"31") {
    grade_distributions {
      course_offering {
        course {
          description
          id
        }
      }
    }
  }
}

@ramanxg ramanxg assigned pranavmreddy and unassigned pranavmreddy Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql graphql related items Story Point 2 Small UI Change, or bugfix. No new tests are required.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants