Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Duplicate meetings due to multiple locations #222

Open
MinhxNguyen7 opened this issue Jan 30, 2023 · 1 comment
Open

Duplicate meetings due to multiple locations #222

MinhxNguyen7 opened this issue Jan 30, 2023 · 1 comment

Comments

@MinhxNguyen7
Copy link
Member

MinhxNguyen7 commented Jan 30, 2023

Original: AntAlmanac/#257

When a section has more than one meeting time, the response will have multiple meetings with the same days and times but different buildings. I'm not sure whether you should modify the API, make a different endpoint, or tell me to stuff it, but I think it should be fixed on the API end.

Reproduction

  1. Query /rest/v0/schedule/soc for any course that has multiple locations, e.g., EECS 170LB.
  2. Look at the meetings array.

image

@ecxyzzy
Copy link
Member

ecxyzzy commented Jan 31, 2023

The data returned by the API is consistent with the data given to us by WebSOC. So this is not a bug.
image

However, I do agree that it is somewhat unwieldy. Would you prefer for meetings with same days and times but differing buildings to be merged into a single object (e.g. the following)?

"meetings": [{
    "days": "Tu",
    "time": " 2:00- 4:50p",
    "bldg": "ET 203, ET 204"
}]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants