Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root font size should be 16px #457

Open
Awesome-E opened this issue Mar 5, 2024 · 1 comment
Open

Root font size should be 16px #457

Awesome-E opened this issue Mar 5, 2024 · 1 comment
Labels
frontend Front End tasks

Comments

@Awesome-E
Copy link
Member

The font size on the root element should be at least 16px. (current is 14px)

Having the text smaller causes inconveniences related to accessibility issues on mobile. One example of this is that tapping on any input fields whose font size is smaller than 16px will cause the page to zoom in for accessibility reasons. In PPC, that is most of the input fields because they inherit the font size from root with 1rem.

(‼️ This will cause a lot of layout shifts when changed)
@Awesome-E Awesome-E added the frontend Front End tasks label Mar 5, 2024
@js0mmer
Copy link
Member

js0mmer commented Mar 6, 2024

Note: semantic ui seems to be the culprit for the root size being 14px

we also have this issue: #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend Front End tasks
Projects
PeterPortal Client
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@js0mmer @Awesome-E