feat: ✨ update time picker #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KevinWu098 Is it possible to validate the start time before the end time on the time picker? Currently I can create a meeting from 11pm - 4pm and it has some unintentional behavior. 
|
seancfong
requested changes
Jun 7, 2024
| return hour.toString().padStart(2, "0"); | ||
| } | ||
|
|
||
| $: $startTime = `${convertTo24Hour(startHour, startPeriod)}:00` as `${string}:${string}`; |
There was a problem hiding this comment.
There is a HourMinuteString type in src/lib/types/chrono.ts and it would be nice to use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #84