Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip files with BZip2 compression? #315

Closed
Numpsy opened this issue Jan 28, 2019 · 4 comments
Closed

Zip files with BZip2 compression? #315

Numpsy opened this issue Jan 28, 2019 · 4 comments
Labels
bzip2 enhancement Feature request or other improvements of existing functionality zip Related to ZIP file format

Comments

@Numpsy
Copy link
Contributor

Numpsy commented Jan 28, 2019

Is there any official position on supporting Zip files that use BZip2 compression?

I tried wiring it up out of interest @

Numpsy@c88def5 Numpsy@0ece0c9

and it does basically seem to work with some interop with 7-Zip (though reading AES encrypted files doesn't work due to issues reading bytes from the AES stream).

Is this something that would be of interest for official support?

@piksel
Copy link
Member

piksel commented Jan 30, 2019

I have neither encountered zipfiles with bz2 compression, nor seen any requests for us to support it. But since it seems like we basically already have all the foundation needed, it shouldn't add much of a support cost to maintain.

I'm guessing you had some use for this, since you found the incorrect Enum value and now this?

@piksel piksel added enhancement Feature request or other improvements of existing functionality bzip2 zip Related to ZIP file format labels Jan 30, 2019
@Numpsy
Copy link
Contributor Author

Numpsy commented Jan 30, 2019

I work on a project that uses SharpZipLib to access zip files and process their contents (though that only needs to decompress rather than create), and I was thinking that BZip2 support might hypothetically be useful (I say hypothetically, because although 7-Zip can create such files, I don't know how much they really show up in the wild).

In any case, looks like it might be doable just using the existing BZip2 support, so worth a look.

@Numpsy
Copy link
Contributor Author

Numpsy commented Jan 30, 2019

I guess that #23 would be of more 'real' use, though more work as well.

@Numpsy
Copy link
Contributor Author

Numpsy commented Oct 9, 2020

I'll close this now that #355 is merged - can open seperate issues if any bugs are found in it

@Numpsy Numpsy closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bzip2 enhancement Feature request or other improvements of existing functionality zip Related to ZIP file format
Projects
None yet
Development

No branches or pull requests

2 participants