-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server alias names are not considered when searching renamed MDs #338
Comments
I'm not sure about the consequences of this bug... probably the only consequence is that mod_md sometimes requests a new certificate when it could use an existing one. |
So, the scenario where this bites is a vhost change of This would lead the domain being subject to cert generation and give it a fallback cert until this succeeds. Although a possibly working certificate is in the store. I added test_md_702_033 in e5d131b for this situation. The rename detection is working. |
Thank you for the test! In this scenario, it does not work:
The code in |
Ah, ok. Well, I think I can live with that the server gets a new cert then. |
Yes, mod_md needs to get a new certificate. If it would find the old MD, it could rename the directory |
No change planned on this. |
The alias names of a new virtual host are not considered for the detection whether the new virtual host is actually an old virtual host that has been renamed (
md_reg_sync_start()
inmd_reg.c
). But the alias names should be considered ifMDMembers auto
is set.The alias names are handled in
auto_add_domains()
inmod_md.c
, but that's too late.md_reg_sync_start()
is called earlier.The text was updated successfully, but these errors were encountered: