- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static typing extremely slow #651
Comments
+1 and I also see tsc build failures with out of memory errors.
I have got plenty of memory on my machine (32G) and allocating more to the node process with a flag doesn't do anything either. |
Stubbing out the type definitions and replacing them with a simpler version seems to work for me. But, obviously, the downside is that the types are not complete. In any case, if you are interested, here's my temporary solution, mantine-datatable.d.ts
ts-config.json
|
I think the main problem is intersection types, I convert most of them to static types and make all properties optional, It may break some things but this one helps me |
I was wondering, is it the intersection types, or my way of defining the accessors like I'd be grateful if someone could find the time to investigate this a bit... I'm open to rewrite the accessor definitions if that speeds things up. |
I think the accessor type is fine, I tried to comment on some parts of DataTableProps and I realized when I commented on the props that have intersection types then I could get suggestions faster, like this one So I removed the part that has "never" type. I think I understand your idea that you tried to make the suggestions more correctly, but I don't know, maybe that is a problem |
Describe the bug
This isn't a bug per se, I might be doing something wrong with the library! When I am working on the file that has the datatable in it in VA Code, static typing with typescript becomes incredibly slow (e.g. I have to wait up to 10s for the typing to update after adding a line of code).
To Reproduce
Here is my file in case there is something obvious I missed.
Expected behavior
I expect no performance change compared to the rest of my codebase (typescript-wise).
I am on version
7.12.4
but it was like this before as well.Thanks !
The text was updated successfully, but these errors were encountered: