Fixup typeerror message and add test covering check in geodataframe

icesat2py · Oct 30, 2024 · 27de548 · 27de548
1 parent 3f923a6
commit 27de548
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/icepyx/core/spatial.py b/icepyx/core/spatial.py
@@ -79,7 +79,7 @@ def geodataframe(
 
     if isinstance(spatial_extent, str):
         raise TypeError(
-            f"Expected list of floats or Polygon, received {spatial_extent=}"
+            f"Expected list of floats, list of tuples of floats, or Polygon, received {spatial_extent=}"
         )
 
     if isinstance(spatial_extent, Polygon):

diff --git a/icepyx/tests/unit/test_spatial.py b/icepyx/tests/unit/test_spatial.py
@@ -437,6 +437,13 @@ def test_gdf_raises_error_bounding_box_file():
         spat.geodataframe("bounding_box", "/fake/file/somewhere/polygon.shp", file=True)
 
 
+def test_gdf_raises_error_string_file_false():
+    with pytest.raises(TypeError):
+        spat.geodataframe(
+            "bounding_box", "/fake/file/somewhere/polygon.shp", file=False
+        )
+
+
 # Potential tests to include once multipolygon and complex polygons are handled
 
 # def test_gdf_from_strpoly_one_simple():