Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end method wrong implementation #9

Closed
iccicci opened this issue Dec 16, 2016 · 0 comments
Closed

end method wrong implementation #9

iccicci opened this issue Dec 16, 2016 · 0 comments
Assignees
@iccicci

Comments

@iccicci
Copy link
Owner

iccicci commented Dec 16, 2016

I realized that end method is not correctly implemented.

Reguardless what stream.Writable.end documentation says, due to this bug end method works properly only if called in following forms:

rsf.end();
rfs.end(chunk);
rfs.end(callback);

In all other cases, the parameters encoding and callback are ignored.
@iccicci iccicci self-assigned this Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccicci iccicci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iccicci