Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle does not close #11

Closed
Delagen opened this issue Apr 26, 2017 · 5 comments
Closed

Handle does not close #11

Delagen opened this issue Apr 26, 2017 · 5 comments

Comments

@Delagen
Copy link

Delagen commented Apr 26, 2017

While wrote own implementation on TS found that

https://github.com/iccicci/rotating-file-stream/blob/master/compress.js#L246

does not close handle of file, that cause test failing when removing previous results
due EPERM with directory is not empty
@iccicci
Copy link
Owner

iccicci commented Apr 26, 2017

Thank you,

I'll fix this asap

@Delagen
Copy link
Author

Delagen commented Apr 26, 2017

It simply can be replaced with writeFile call with empty string

@iccicci
Copy link
Owner

iccicci commented Apr 26, 2017

That will replace file content.
More than this I have to take care of tests and coverage....

It's a bit more complicated, but I'll fix that asap anyway.

@Delagen
Copy link
Author

Delagen commented Apr 26, 2017 

fs.writeFile(file, data,{flag:"a"}, callback)

@iccicci
Copy link
Owner

iccicci commented Apr 26, 2017

Interesting, I missed that.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Delagen @iccicci