-
Notifications
You must be signed in to change notification settings - Fork 247
Evaluation: Avoid dependency on local culture settings. #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #759 +/- ##
===================================
- Coverage 67% 67% -0%
===================================
Files 104 104
Lines 4519 4517 -2
Branches 1106 1106
===================================
- Hits 3014 3012 -2
Misses 1072 1072
Partials 433 433
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, just 2 typos (besides Sonar recommendations)
175af14 to
ececc0b
Compare
|
|
Thanks for the review! |




The use of
CultureInfo.CurrentCulture.Calendaris one of the remaining dependencies on the local system settings, which is fixed with this PR.