Skip to content

Conversation

@minichma
Copy link
Collaborator

@minichma minichma commented Apr 1, 2025

The use of CultureInfo.CurrentCulture.Calendar is one of the remaining dependencies on the local system settings, which is fixed with this PR.

@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ Your project status has failed because the head coverage (67%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #759   +/-   ##
===================================
- Coverage    67%    67%   -0%     
===================================
  Files       104    104           
  Lines      4519   4517    -2     
  Branches   1106   1106           
===================================
- Hits       3014   3012    -2     
  Misses     1072   1072           
  Partials    433    433           
Files with missing lines Coverage Δ
Ical.Net/Evaluation/Evaluator.cs 89% <ø> (-1%) ⬇️
Ical.Net/Evaluation/RecurrencePatternEvaluator.cs 91% <100%> (+<1%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@minichma minichma marked this pull request as ready for review April 1, 2025 07:33
@minichma minichma requested a review from axunonb April 1, 2025 07:33
Copy link
Collaborator

@axunonb axunonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just 2 typos (besides Sonar recommendations)

@minichma minichma force-pushed the work/minichma/feature/calendar_invariant branch from 175af14 to ececc0b Compare April 1, 2025 13:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@minichma minichma merged commit aa1c01d into main Apr 1, 2025
6 of 8 checks passed
@minichma minichma deleted the work/minichma/feature/calendar_invariant branch April 1, 2025 17:41
@minichma
Copy link
Collaborator Author

minichma commented Apr 1, 2025

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants