Fix issue with BYWEEKNO=1 where UNTIL lies in the year prior to the year of the week of the last occurrence.
#752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to the year of the week of the last occurrence.
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (66%) is below the target coverage (80%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #752 +/- ##
===================================
Coverage 66% 66%
===================================
Files 104 104
Lines 4611 4617 +6
Branches 1146 1147 +1
===================================
+ Hits 3047 3055 +8
Misses 1129 1129
+ Partials 435 433 -2
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
minichma
force-pushed
the
work/minichma/bugfix/until_weekno1
branch
from
2a297a0 to
dee8ef0
Compare
…he year of the week of the last occurrence.
minichma
force-pushed
the
work/minichma/bugfix/until_weekno1
branch
from
dee8ef0 to
5504cb4
Compare
|
axunonb
approved these changes
Mar 10, 2025
Collaborator
axunonb
left a comment
axunonb
left a comment
There was a problem hiding this comment.
Another edge case fixed, very good
| } | ||
| } | ||
|
|
||
| private static CalDateTime? GetSearchEndDate(CalDateTime? periodEnd, RecurrencePattern pattern) |
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where
BYWEEKNO=1is specified, week no 1 may start in the year prior to the one it belongs to. If both, the last occurrence andUNTILlie in the year prior to the year the corresponding week belongs to,UNTILhas not been handled correctly, which is fixed with this PR.E.g. the following case is fixed, which was missing the last instance prior to the fix:
fixes #751