Use specified culture/format provider when provided to CalDateTime.ToString #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to make a change to CalDateTime.ToString and want to be confident that I'm not breaking existing functionality. These tests pass against the current code.
When using the default format string, callers still want to be able to specify a formatter to make sure that dates are formatted in their preferred way.
CalDateTime * to use DateOnly and TimeOnly types * Added SetValue(DateOnly date, TimeOnly? time, DateTimeKind kind) to set the value of the date and time properly. * Refactored `ToString` overloads to convert the date and time to a string representation. * marked some properties as obsolete. * Updated related tests and methods to accommodate these changes. * Increase code coverage > 90% DateTimeSerializer * Added validation in the `SerializeToString` method to ensure the TZID parameter is correctly handled based on whether the date-time is in UTC. * Improved the Deserialize method to handle both full date-time and date-only strings, initializing the DateOnly and TimeOnly parts accordingly. * Increase code coverage > 90% Added new package reference `Portable.System.DateTimeOnly` for netstandard2.0 and netstandard2.1 for compatibility with net6.0 and later. Fixes ical-org#630
|
Collaborator
|
The PR is included in #631. Thanks for posting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ToString method on CalDateTime has useful logic to render the date and/or time components, but this rendering ignores the format provider and always uses the current culture. The format provider is currently used when the format string is specified, but not otherwise.
This PR adds some characterisation tests and alters ToString to use the format provider for date formatting.