feat(impala): add tbl_properties to create_table
#9839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
approved these changes
Aug 14, 2024
gforsyth
added a commit
that referenced
this pull request
Dec 5, 2024
This removes the `ImpalaTable` subclass. Relevant methods that were on that class have been moved to the `Backend` class instead. We used to have backend-specific subclasses of `Table` that added some backend-specific methods. Most of those were removed in prior releases, `ImpalaTable` was the last remaining one. As this is a breaking change, we should hold off on merging this until we're ready to start prepping for a 10.0 release. Depends on #9839. Fixes #9365. --------- Co-authored-by: Gil Forsyth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBLPROPERTIEScan be set on table creation. Exposing this lets us un-xfail a few tests by setting the requiredTBLPROPERTIESto make them work.