Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(druid): handle typed nulls where possible #9452

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 27, 2024

Fixes a bug where we were not casting nulls to a specific type where we should.

Discovered during #9451.

@cpcloud cpcloud added this to the 9.2 milestone Jun 27, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis druid The Apache Druid backend labels Jun 27, 2024
@cpcloud cpcloud requested a review from gforsyth June 27, 2024 13:45
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like something that could use a proper test to avoid regression, but looks good overall!

@cpcloud
Copy link
Member Author

cpcloud commented Jun 27, 2024

Gonna rebase, which should pick up another test. It's not specific for this case but the code path does hit it.

@cpcloud cpcloud force-pushed the fix-druid-null-handling branch from 434d115 to 0de58bf Compare June 27, 2024 14:57
@cpcloud cpcloud force-pushed the fix-druid-null-handling branch from 0de58bf to 950be71 Compare June 27, 2024 14:57
@cpcloud cpcloud enabled auto-merge (squash) June 27, 2024 14:58
@cpcloud cpcloud merged commit 33ec754 into ibis-project:main Jun 27, 2024
76 checks passed
@cpcloud cpcloud deleted the fix-druid-null-handling branch June 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis druid The Apache Druid backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants