Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pyspark): builtin udf support #9191

Merged
merged 4 commits into from
May 14, 2024
Merged

feat(pyspark): builtin udf support #9191

merged 4 commits into from
May 14, 2024

Conversation

ted0928
Copy link
Contributor

@ted0928 ted0928 commented May 14, 2024

Description of changes

support builtin udf by using @ibis.udf.scalar.builtin annotation in spark backend.

modified spark backend _register_udfs to accept builtin udf.
modified spark compiler sql_name to remain the origin function name.

@ted0928 ted0928 force-pushed the main branch 2 times, most recently from d704b90 to 7591e29 Compare May 14, 2024 07:26
@ted0928 ted0928 marked this pull request as ready for review May 14, 2024 07:51
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request!

ibis/backends/pyspark/compiler.py Outdated Show resolved Hide resolved
@cpcloud cpcloud added this to the 9.1 milestone May 14, 2024
@cpcloud cpcloud added feature Features or general enhancements pyspark The Apache PySpark backend labels May 14, 2024
@cpcloud cpcloud enabled auto-merge (squash) May 14, 2024 11:34
@cpcloud
Copy link
Member

cpcloud commented May 14, 2024

@ted0928 Thanks for the PR, great to see some PySpark activity here!

@cpcloud cpcloud merged commit 142c105 into ibis-project:main May 14, 2024
86 checks passed
@ted0928
Copy link
Contributor Author

ted0928 commented May 14, 2024

@ted0928 Thanks for the PR, great to see some PySpark activity here!

Very glad to contribute!

@krzysztof-kwitt
Copy link
Contributor

I'm wondering if it's worth adding some documentation to PySpark backend page, as UDfs are not visible in the Operation Support Matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements pyspark The Apache PySpark backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants