Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake): implement array map and array filter #9178

Merged
merged 1 commit into from
May 13, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 13, 2024

Adds array map and filter implementations to the Snowflake backend. Thanks again @krzysztof-kwitt for the idea!

The main limitation for the Snowflake versions of these APIs is that your lambda cannot reference any columns outside the scope of the lambda, which means the scope is limited to the lambda parameter and constants.

@cpcloud cpcloud added this to the 9.1 milestone May 13, 2024
@cpcloud cpcloud added feature Features or general enhancements snowflake The Snowflake backend labels May 13, 2024
@cpcloud cpcloud requested a review from gforsyth May 13, 2024 12:50
@gforsyth
Copy link
Member

🐚 pytest -m snowflake ibis/backends/tests/test_array.py
================================ test session starts ================================
platform linux -- Python 3.12.2, pytest-8.2.0, pluggy-1.5.0
Using --randomly-seed=974300145
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/gil/github.com/ibis-project/ibis
configfile: pyproject.toml
plugins: anyio-4.3.0, hypothesis-6.100.4, snapshot-0.9.0, randomly-3.15.0, mock-3.14.0, benchmark-4.0.0, timeout-2.3.1, cov-5.0.0, repeat-0.9.3, clarity-1.0.1, pytest_httpserver-1.0.10, xdist-3.6.1
collected 2760 items / 2622 deselected / 138 selected                               

ibis/backends/tests/test_array.py ........................................... [ 31%]
.............x..............x.x..............x............................... [ 86%]
..........x.......                                                            [100%]

============ 133 passed, 2622 deselected, 5 xfailed in 135.93s (0:02:15) ============

@gforsyth gforsyth merged commit 9b42751 into ibis-project:main May 13, 2024
83 checks passed
@cpcloud cpcloud deleted the array-map-and-filter branch July 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants