Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backends): introducing ibish the infinite scale backend you always wanted #8785

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 26, 2024

This is a very serious business PR to productionize Ibis, starting at the beginning of April.

@cpcloud cpcloud added this to the 9.0 milestone Mar 26, 2024
@cpcloud cpcloud added feature Features or general enhancements docs Documentation related issues or PRs labels Mar 26, 2024
@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch 8 times, most recently from 818f90f to 1a11130 Compare March 27, 2024 14:33
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's obviously a joke but also a great explainer.

I feel like you're doing yourself a disservice by not including any explain output in the blog post

docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
ibis/backends/unix/__init__.py Outdated Show resolved Hide resolved
ibis/backends/unix/__init__.py Outdated Show resolved Hide resolved
docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch 3 times, most recently from b8bdabe to 496edc6 Compare March 27, 2024 17:34
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, still incredible. one small issue introduced in my last review

docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch 3 times, most recently from 8a79d54 to 0560469 Compare March 29, 2024 12:12
@cpcloud cpcloud marked this pull request as ready for review March 29, 2024 12:13
@cpcloud cpcloud requested a review from gforsyth March 29, 2024 12:13

### Things to avoid doing

- Putting this into production

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless......

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This final line is the real April Fool's joke

Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. I took it for a drive and I'm thinking new default backend?

One formatting question, non-blocking, :shipit: when the time is right.

docs/posts/unix-backend/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Mar 29, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Mar 29, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Mar 29, 2024

@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch 2 times, most recently from 1dbba89 to c22ca55 Compare March 29, 2024 14:08
@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch 3 times, most recently from 6fb848d to ab490bb Compare March 29, 2024 14:15
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Mar 29, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Mar 29, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Mar 29, 2024

pip install ibish
```

Like all production-ready libraries `ibish` depends on the latest commit of `ibis-framework`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IF (big if) we wanted to help people get this up-and-running, they could install a recent nightly and it would work (but is that a good thing?)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

massive if

@cpcloud cpcloud force-pushed the extremely-serious-production-ready-backend branch from ab490bb to 4c9cb42 Compare April 1, 2024 10:34
@cpcloud cpcloud enabled auto-merge (squash) April 1, 2024 10:38
@cpcloud cpcloud merged commit 1d51243 into ibis-project:main Apr 1, 2024
15 checks passed
@cpcloud cpcloud deleted the extremely-serious-production-ready-backend branch April 1, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants